Re: [RFC][PATCH] affs_lookup: switch to d_splice_alias()

[Fabian Frederick <fabf@xxxxxxxxx>]

> On 13 May 2018 at 18:03 Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:
> 
> 
> Making something exportable takes more than providing ->s_export_ops.
> In particular, ->lookup() *MUST* use d_splice_alias() instead of
> d_add().
> 
> Reading Documentation/filesystems/nfs/Exporting would've been a good idea;
> as it is, exporting AFFS is badly (and exploitably) broken.

Hi Al,

	Could you tell me where Affs is broken ? affs_get_parent() uses d_obtain_alias() and
your patch fixes the lookup. Do you suggest other updates or to mark nfs support experimental in AFFS or 
 something else ?

(btw, other export functions are
fh_to_dentry using generic_fh_to_dentry()
fh_to_parent using generic_fh_to_parent()
)

Regards,
Fabian