Re: [PATCH 3/3] statx: add STATX_ATTRIBUTES flag

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Miklos Szeredi <mszeredi@xxxxxxxxxx>
Subject: Re: [PATCH 3/3] statx: add STATX_ATTRIBUTES flag
From: David Howells <dhowells@xxxxxxxxxx>
Date: Thu, 18 Oct 2018 16:22:35 +0100
Cc: dhowells@xxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-api@xxxxxxxxxxxxxxx, Michael Kerrisk <mtk.manpages@xxxxxxxxx>, Andreas Dilger <adilger@xxxxxxxxx>, Florian Weimer <fw@xxxxxxxxxxxxx>, Amir Goldstein <amir73il@xxxxxxxxx>
In-reply-to: <20181018131125.6303-3-mszeredi@redhat.com>
Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903

Miklos Szeredi <mszeredi@xxxxxxxxxx> wrote:

> +	/* Having anything in attributes_mask means attributes are valid. */
> +	if (tmp.stx_attributes_mask)
> +		tmp.stx_mask |= STATX_ATTRIBUTES;

That would be superfluous, since userspace can make this check too.

Note that fsinfo() might inform you better - if and when it arrives.

David

References:
- [PATCH 3/3] statx: add STATX_ATTRIBUTES flag
  - From: Miklos Szeredi
- [PATCH 1/3] orangefs: fix request_mask misuse
  - From: Miklos Szeredi

Prev by Date: Re: [PATCH 4/5] block: introduce helpers for allocating IO buffers from slab
Next by Date: Re: [PATCH 0/5] block: introduce helpers for allocating io buffer from slab
Previous by thread: Re: [PATCH 2/3] uapi: get rid of STATX_ALL
Next by thread: Re: [PATCH 1/3] orangefs: fix request_mask misuse
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [Samba] [Device Mapper] [CEPH Development]