On Wed 17-10-18 20:05:37, Matthew Bobrowski wrote: > diff --git a/include/linux/fsnotify_backend.h b/include/linux/fsnotify_backend.h > index 329ac6684326..96616651220c 100644 > --- a/include/linux/fsnotify_backend.h > +++ b/include/linux/fsnotify_backend.h > @@ -44,8 +44,9 @@ > #define FS_Q_OVERFLOW 0x00004000 /* Event queued overflowed */ > #define FS_IN_IGNORED 0x00008000 /* last inotify event here */ > > -#define FS_OPEN_PERM 0x00010000 /* open event in an permission hook */ > +#define FS_OPEN_PERM 0x00010000 /* open event in a permission hook */ This hunk would belong to patch 1 instead of this one. > #define FS_ACCESS_PERM 0x00020000 /* access event in a permissions hook */ > +#define FS_OPEN_EXEC_PERM 0x00040000 /* open/exec in a permission hook */ > > #define FS_EXCL_UNLINK 0x04000000 /* do not send events if object is unlinked */ > #define FS_ISDIR 0x40000000 /* event occurred against dir */ > @@ -64,7 +65,7 @@ > FS_CLOSE_WRITE | FS_CLOSE_NOWRITE | FS_OPEN |\ > FS_MOVED_FROM | FS_MOVED_TO | FS_CREATE |\ > FS_DELETE | FS_OPEN_PERM | FS_ACCESS_PERM |\ > - FS_OPEN_EXEC) > + FS_OPEN_EXEC | FS_OPEN_EXEC_PERM) > > #define FS_MOVE (FS_MOVED_FROM | FS_MOVED_TO) > You seem to be missing an update of ALL_FSNOTIFY_PERM_EVENTS to also include FS_OPEN_EXEC_PERM. Otherwise the patch looks good to me. Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR
