Re: [PATCH 2/4] fscache: Fix race in fscache_op_complete() due to split atomic_sub & read

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Andrea Parri <andrea.parri@xxxxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH 2/4] fscache: Fix race in fscache_op_complete() due to split atomic_sub & read
From: David Howells <dhowells@xxxxxxxxxx>
Date: Wed, 17 Oct 2018 16:32:13 +0100
Cc: dhowells@xxxxxxxxxx, gregkh@xxxxxxxxxxxxxxxxxxxx, Kiran Kumar Modukuri <kiran.modukuri@xxxxxxxxx>, viro@xxxxxxxxxxxxxxxxxx, sandeen@xxxxxxxxxx, linux-cachefs@xxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <20181017151134.GA8966@andrea>
Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903

Andrea Parri <andrea.parri@xxxxxxxxxxxxxxxxxxxx> wrote:

> > Fix this by using atomic_sub_return() instead of two calls.
> 
> Seems a case for atomic_sub_return_relaxed()... why not?

Ummm...  In that case, should it be atomic_sub_return_release()?

David

Follow-Ups:
- Re: [PATCH 2/4] fscache: Fix race in fscache_op_complete() due to split atomic_sub & read
  - From: David Howells
- Re: [PATCH 2/4] fscache: Fix race in fscache_op_complete() due to split atomic_sub & read
  - From: Andrea Parri

References:
- Re: [PATCH 2/4] fscache: Fix race in fscache_op_complete() due to split atomic_sub & read
  - From: Andrea Parri
- [PATCH 0/4] FS-Cache: Miscellaneous fixes
  - From: David Howells
- [PATCH 2/4] fscache: Fix race in fscache_op_complete() due to split atomic_sub & read
  - From: David Howells

Prev by Date: Re: WARNING: possible recursive locking detected in mnt_want_write/mnt_want_write_file_path
Next by Date: Re: [PATCH 31/34] vfs: syscall: Add fspick() to select a superblock for reconfiguration [ver #12]
Previous by thread: Re: [PATCH 2/4] fscache: Fix race in fscache_op_complete() due to split atomic_sub & read
Next by thread: Re: [PATCH 2/4] fscache: Fix race in fscache_op_complete() due to split atomic_sub & read
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [Samba] [Device Mapper] [CEPH Development]