Re: [PATCH] hfsplus: return file attributes on statx

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2018-10-16 at 20:38 -0300, Ernesto A. Fernández wrote:
> On Mon, Oct 15, 2018 at 05:26:23PM -0700, Viacheslav Dubeyko wrote:
> > On Sun, 2018-10-14 at 13:35 -0300, Ernesto A. Fernández wrote:
> > > The immutable, append-only and no-dump attributes can only be retrieved
> > > with an ioctl; implement the ->getattr() method to return them on statx.
> > > Do not return the inode birthtime yet, because the issue of how best to
> > > handle the post-2038 timestamps is still under discussion.
> > > 
> > 
> > As far as I can see, the stable branch doesn't contain the inode
> > birthtime yet. So, I believe we have no troubles with it.
> 
> What stable branch?  What are you talking about?  Of course the inode
> birthtime is in the code, how could it not be?
> 

I mean the latest stable kernel branch
(git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git).

> > 
> > > This patch is needed to pass xfstests generic/424.
> > 
> > Do you mean that the patch isn't been tested yet? Do it needs to wait
> > the testing result report before taking the patch? Otherwise, it looks
> > weird to have such remark in the comment section of the patch.
> 
> Look, I'm not a native speaker either, but I think that's a pretty simple
> sentence.  You need this patch if you want xfstests generic/424 to pass.
> 

Currently, it sounds confusing. It makes sense to rework the comment
section and to resend the second version of the patch.

Thanks,
Vyacheslav Dubeyko.





[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux