On Fri, Oct 05, 2018 at 03:03:16PM +0200, Carlos Maiolino wrote: > Commit 09230435dffdb13de507e5e40b524b0069fc5c7b refactor iomap_dio_actor > into two different helpers for bio based IO and hole IO, although, the > latter doesn't check for IO alignment anymore. > > Move the DIO alignment check up into the caller, so all iomap DIO has > alignment checked. Why? The only reason to check alignmnet for actual I/O is because we have to. There is no requirement to align holes. > Christoph, I tagged this patch as RFC, because I couldn't really identify if you > intentionally dropped the alignment check for holes and inline actors, if you > didn't drop the alignment check intentionally, please consider it as a normal > patch. The primary intent was to simplify the code and not enforce alignment for inline data support.