NeilBrown <neilb@xxxxxxxx> wrote: > Thanks for the review. > As afs doesn't use the generic xattr code and doesn't call > setattr_prepare(), this is all largely irrelevant for afs. Yeah - there's no xattr support yet. > afs_permission() will probably only get MAY_ACT_AS_OWNER passed when > someone uses fcntl(F_SETFL) to set the O_NOATIME flag. There's no atime in AFS. > Currently a permission test based on UID is performed which, as you say, > is wrong. My patch simply preserved this current (wrong) behaviour. > Shall I change it to always allow access, like with NFS? You have to have an appropriate key to be able to do anything not granted to anonymous with the server. If the server says your key (or lack thereof) is allowed to do something, you can do it; if it does not, you can't. > Probably O_NOATIME is ignored, in which case f_op->check_flags should > probably report -EINVAL (???) ... or might that cause a regression? No atime. I just ignore things like O_NOATIME. You will be able to query the filesystem with fsinfo() hopefully soon to find out if there is an atime and if you can disable it. Davod
