On Thu, Oct 4, 2018 at 11:41 AM Jan Kara <jack@xxxxxxx> wrote: > > On Thu 04-10-18 00:25:37, Amir Goldstein wrote: > > Also define the FANOTIFY_EVENT_FLAGS consisting of the extra flags > > FAN_ONDIR and FAN_ON_CHILD. > > > > Signed-off-by: Amir Goldstein <amir73il@xxxxxxxxx> > ... > > /* Events that may be reported to user */ > > #define FANOTIFY_OUTGOING_EVENTS (FANOTIFY_EVENTS | \ > > FANOTIFY_PERM_EVENTS | \ > > FAN_Q_OVERFLOW) > > > > +#define ALL_FANOTIFY_EVENT_BITS (FANOTIFY_EVENTS | \ > > + FANOTIFY_PERM_EVENTS | \ > > + FANOTIFY_EVENT_FLAGS | \ > > + FANOTIFY_OUTGOING_EVENTS) > > + > > No point in repeating FANOTIFY_EVENTS | FANOTIFY_PERM_EVENTS here when > they are already included on FANOTIFY_OUTGOING_EVENTS, right? I can fix > that up myself, just wanted to point it out. It's fine to me. Thanks, Amir.