On Thu 04-10-18 00:25:39, Amir Goldstein wrote: > inotify and dnotify are always interested in events on directories. > fanotify is interested in events on directories only if user requested > them by flag FAN_ONDIR. > > For the fanotify supported events on directories (open/access/close), > if there is no inotify/dnotify associated marks and if none of the > associated fanotify marks have the FS_ISDIR flag, we can skip iterating > the marks and we avoid taking the srcu_read_lock() for all events on > directories. > > In order to enable this check in fsnotify() we set the FS_ISDIR flag > explicitly on all dnotify/inotify marks. > > Signed-off-by: Amir Goldstein <amir73il@xxxxxxxxx> > --- > fs/notify/dnotify/dnotify.c | 5 +++-- > fs/notify/fsnotify.c | 9 ++++++++- > fs/notify/inotify/inotify_user.c | 4 ++-- > 3 files changed, 13 insertions(+), 5 deletions(-) Looks good, except I think you forgot to convert kernel/audit_watch.c and kernel/audit_fsnotify.c which also need to set FS_ISDIR... Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR
