On (09/18/18 07:06), Guenter Roeck wrote: > > So the check either better be > > > > if (fc->ops && fc->ops->reconfigure) > > > > Since there are multiple instances of fs_context where fc->ops isn't set, > this check would be needed wherever fc->ops is dereferenced. Right. If fc is always guaranteed to be properly zeroed-out. This is true for kzalloc-ed fc's, but not necessarily so in any other case. -ss