Oleg Nesterov <oleg@xxxxxxxxxx> writes: > On 09/16, Eric W. Biederman wrote: >> >> Oleg's patch to remove get_files_struct from proc means we don't need >> two counts in files_struct. > > So it seems you agree with this patch at least in general. I do I think in the context we are looking at things finding a way not to need to bump files_struct->count looks like it will simplify a lot of things and there are not many cases we need to consider. I have been thorough and mentioned the binder case and other case but that isn't because I disagree I simply don't want us to overlook weird or tricky cases. It appears that the more often that we look at these bits the better a solution we wind up writing. > OK, if nobody else objects I'll split this patch and send the series > tomorrow. No objection from me. >> Eric W. Biederman (3): >> exec: Move unshare_files down to avoid locks being dropped on exec. >> exec: Simplify unshare_files >> exec: Remove reset_files_struct > > Reviewed-by: Oleg Nesterov <oleg@xxxxxxxxxx> Eric
