Re: [PATCH 2/3] cachefiles: drop direct usage of ->bmap method.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Carlos Maiolino <cmaiolino@xxxxxxxxxx>
Subject: Re: [PATCH 2/3] cachefiles: drop direct usage of ->bmap method.
From: Christoph Hellwig <hch@xxxxxx>
Date: Fri, 14 Sep 2018 15:23:53 +0200
Cc: linux-fsdevel@xxxxxxxxxxxxxxx, hch@xxxxxx, sandeen@xxxxxxxxxx, david@xxxxxxxxxxxxx
In-reply-to: <20180912122536.31977-3-cmaiolino@redhat.com>
User-agent: Mutt/1.5.17 (2007-11-01)

On Wed, Sep 12, 2018 at 02:25:35PM +0200, Carlos Maiolino wrote:
> Replace the direct usage of ->bmap method by a bmap() call.

Would be nice to have some real error handling instead of the assert
on an error return, but otherwise this looks fine:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

Follow-Ups:
- Re: [PATCH 2/3] cachefiles: drop direct usage of ->bmap method.
  - From: Carlos Maiolino

References:
- [PATCH 0/3] Replace direct ->bmap calls by bmap() with error support
  - From: Carlos Maiolino
- [PATCH 2/3] cachefiles: drop direct usage of ->bmap method.
  - From: Carlos Maiolino

Prev by Date: Re: [PATCH 1/3] fs: Enable bmap() function to properly return errors
Next by Date: Re: [PATCH 3/3] ecryptfs: drop direct calls to ->bmap
Previous by thread: [PATCH 2/3] cachefiles: drop direct usage of ->bmap method.
Next by thread: Re: [PATCH 2/3] cachefiles: drop direct usage of ->bmap method.
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [Samba] [Device Mapper] [CEPH Development]

Powered by Linux