On 09/11/2018 06:02 PM, Dave Chinner wrote: > On Tue, Sep 11, 2018 at 03:18:23PM -0400, Waiman Long wrote: >> The nr_dentry_unused per-cpu counter tracks dentries in both the >> LRU lists and the shrink lists where the DCACHE_LRU_LIST bit is set. >> The shrink_dcache_sb() function moves dentries from the LRU list to a >> shrink list and subtracts the dentry count from nr_dentry_unused. This >> is incorrect as the nr_dentry_unused count Will also be decremented in >> shrink_dentry_list() via d_shrink_del(). To fix this double decrement, >> the decrement in the shrink_dcache_sb() function is taken out. >> >> Fixes: 4e717f5c1083 ("list_lru: remove special case function list_lru_dispose_all." >> >> Signed-off-by: Waiman Long <longman@xxxxxxxxxx> > Please add a stable tag for this. > > Otherwise looks fine. > > Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> > I will add the cc:stable tag. Cheers, Longman