On Tue, Mar 20, 2018 at 12:02:57PM -0400, bfields@xxxxxxxxxxxx wrote: > On Tue, Mar 20, 2018 at 03:13:47PM +0000, Trond Myklebust wrote: > > Right now, the knfsd threads are regular kernel threads, with each > > thread appearing to userspace to be a process in its own right. > > Is there any reason why we could not assign them a group pid that would > > allow the fl_nspid mechanism to work (i.e. set task->group_leader)? > > Huh, OK, I hadn't thought about that. Thinking about it: as far as I can tell that's not meant to be modified on a running thread, so we need to create the thread the right way--all the nfsd threads need to be children of the same thread. Currently we're using kthead_create() which makes them all children of kthreadd. I spent a little time looking into forking threads from existing nfsd threads and started to feel like I was duplicating a lot of kthread code. So now I wonder if it's possible to generalize kthreadd somehow. --b.