Andrei Vagin <avagin@xxxxxxxxxx> wrote: > security_fs_context_parse_param() returns 0 if everything is okay. Not quite. It returns 0 to indicate that it processed the argument and that the argument doesn't belong to the filesystem. It returns -ENOPARAM to indicate that the argument should be passed along to the filesystem. Any other error is an actual error. > ret = security_fs_context_parse_param(fc, param); > - if (ret != -ENOPARAM) > + if (ret) So this change is wrong. The change that needs making is to the documentation - in particular lsm_hooks.h. David
