On Mon, Aug 27, 2018 at 09:43:43AM -0700, Andi Kleen wrote: > > Adding linux-fsdevel. Keeping full quote for context. > > On Mon, Aug 27, 2018 at 10:12:54AM +0200, Carlos Maiolino wrote: > > Essentially, this isn't a XFS problem, and most likely you are using XFS on top > > of some layer like LVM, and/or using snapshots, and your underlying volume went > > read-only behind XFS for some reason. > > Ok, so the blame is assigned, but the question is still how to avoid the > warning: > > (1) either XFS needs to check for read only underlying more often > or > (2) the warning needs to be removed. > > I assume (2) is far easier. Is (1) even possible without races? I doubt (1) is possible to handle at all. e.g. What's the filesystem supposed to do when the device goes RO under it without warning? We've now got a heap of dirty state in memory that we can't write, so in reality if this ever happens our only option is to shutdown the filesystem, toss everything away and unmount it. And because the device is now read only, we can't get the filesystem back into a consistent state by mounting it again because it can't run log recovery as that requires writing to the device. IOWs, having devices turn read only underneath active read/write filesystems without warning is an unrecoverable failure from the filesystem perspective. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx
