Hi again: On Mon, Nov 27, 2017 at 04:36:54PM -0300, Ernesto A. Fernández wrote: > It would be good to have some feedback on the use of code under the > Unicode License, I don't know if that can be a problem. > > To Ting-Chang Hou: This patch is slightly different from the one you > tested with your mac. You are still tagged as Tested-by, but you may > want to check again that I have not broken anything. > > Thanks, > Ernest > > -- >8 -- > Subject: [PATCH] hfsplus: fix decomposition of Hangul characters > > Files created under macOS become essentially unusable under linux if > their names contain any Hangul, and vice versa. > > This happens because the normalization of Hangul characters is a special > case: it can be done algorithmically, without need of a table. The > hfsplus module deals with Hangul correctly when composing, but > completely forgets about it when performing a decomposition. > > Solve this by using the Hangul decomposition function provided in the > Unicode Standard. It's under the Unicode License, compatible with the > GPL. > > This patch will cause trouble for Hangul filenames already created by > the module in the past. This shouldn't be a special concern because the > main purpose of the module was always sharing with macOS. If a user > actually needs to access such a file the nodecompose mount option should > be enough. > > Reported-by: Ting-Chang Hou <tchou@xxxxxxxxxxxx> > Tested-by: Ting-Chang Hou <tchou@xxxxxxxxxxxx> > Signed-off-by: Ernesto A. Fernández <ernesto.mnd.fernandez@xxxxxxxxx> > It took a while but this patch has been merged now. Thanks again for your report. Ernest
