On Tue, Aug 21, 2018 at 04:05:25PM -0700, Andrew Morton wrote: > On Thu, 12 Jul 2018 15:55:33 -0700 Viacheslav Dubeyko <slava@xxxxxxxxxxx> wrote: > > > On Thu, 2018-07-12 at 18:53 -0300, Ernesto A. Fernández wrote: > > > Check that the hidden directory is not NULL before using it, instead of > > > after. > > > > > > Reported-by: Wen Xu <wen.xu@xxxxxxxxxx> > > > Signed-off-by: Ernesto A. Fernández <ernesto.mnd.fernandez@xxxxxxxxx> > > > --- > > > > It's really hard to understand this simple patch. I believe it makes > > sense to rework the patch slightly with the goal to make it more clear. > > Also, it will be great to add a short comment in the code to explain > > what's wrong. I don't think it's reasonable to expect a comment explaining why we can't dereference NULL. > > I think it makes sense to split this long check condition on something > > more clear, simple and elegant. The long check condition may not be ideal, but there's a lot of code in the module that could use style improvements. I don't think that should be a priority right now, with plenty of serious bugs left to fix. > > No response, causing this patch to be stuck in limbo land? I believe I sent a second version of this patch. Ernest
