Avoid the somewhat hard to grok assignment by using the seq_open_data helper. Signed-off-by: Rasmus Villemoes <linux@xxxxxxxxxxxxxxxxxx> --- fs/seq_file.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/fs/seq_file.c b/fs/seq_file.c index c8c86660f6db..518a72e444d9 100644 --- a/fs/seq_file.c +++ b/fs/seq_file.c @@ -582,10 +582,8 @@ int single_open(struct file *file, int (*show)(struct seq_file *, void *), op->next = single_next; op->stop = single_stop; op->show = show; - res = seq_open(file, op); - if (!res) - ((struct seq_file *)file->private_data)->private = data; - else + res = seq_open_data(file, op, data); + if (res) kfree(op); } return res; -- 2.16.4
