>>> On 15.08.18 at 14:51, <viro@xxxxxxxxxxxxxxxxxx> wrote: > On Wed, Aug 15, 2018 at 12:19:00AM -0600, Jan Beulich wrote: >> While this is only a start (IOCTL_PRIVCMD_MMAP* and IOCTL_PRIVCMD_DM_OP >> require more work), it at least allows some simple operations (like >> "xl dmesg") which have always been available on XenoLinux to work again >> with a 64-bit kernel underneath a 32-bit distro. >> >> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx> >> Acked-by: Juergen Gross <jgross@xxxxxxxx> > > > Nacked-by: Al Viro <viro@xxxxxxxxxxxxxxxxxx> > > This belongs in drivers/xen/privcmd.c, not in fs/compat_ioctl.c > *ANY* single-driver ioctl definitely should be handled by ->compat_ioctl() > method and any patches dumping such stuff into fs/compat_ioctl.c will be > rejected. Okay, I'll see about doing this; I have to admit I was unaware of ->compat_ioctl()'s existence. It would be rather helpful if the header of compat_ioctl.c indicated what you say. Without that, I've simply gone by the observation that there are things in the file which according to what you say shouldn't be there, and I've then wrongly implied adding the Xen stuff here would be fine. Jan
