On Fri, 2008-03-07 at 17:54 +0100, Miklos Szeredi wrote: > > So I have converted all the xattr internals over to an inode from a > > dentry but there is one issue with that. To set EAs on CIFS they need a > > full path for the file. I don't think we can reconcile using inodes in > > the vfs operation with CIFS needing a path. If you have a suggestion on > > how to handle this I'm more than willing to listen. Everything else > > however seems to be a trivial change. > > Since there are no hardlinks in CIFS (or are there?) it coukld get the > dentry back with d_find_alias(). > > But what's the point? Why is it better to pass the inode, rather than > dentry down to the filesystem? > > Hiding info from lower layers is not generally a good idea if there > are valid uses for it. I don't buy Chritoph's argument, that > filesystems working with paths instead of inodes are inherently > broken. > > Miklos This isn't hiding information from the lower layers. The only use of the dentry is much higher up in the call chain. If you take a look at sys_chmod (another inode attr modifying call) the dentry is really only used in sys_chmod->chown_common->notify_change->fsnotify_change The operations that actually change the inode metadata on disk do not touch the dentry at all except to get the inode(rightly so since it is an INODE operation). Dave -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
