Re: [BUG] mm: truncate: a possible sleep-in-atomic-context bug in truncate_exceptional_pvec_entries()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Mon 13-08-18 11:10:23, Jia-Ju Bai wrote:
> The kernel may sleep with holding a spinlock.
> 
> The function call paths (from bottom to top) in Linux-4.16 are:
> 
> [FUNC] schedule
> fs/dax.c, 259: schedule in get_unlocked_mapping_entry
> fs/dax.c, 450: get_unlocked_mapping_entry in __dax_invalidate_mapping_entry
> fs/dax.c, 471: __dax_invalidate_mapping_entry in dax_delete_mapping_entry
> mm/truncate.c, 97: dax_delete_mapping_entry in
> truncate_exceptional_pvec_entries
> mm/truncate.c, 82: spin_lock_irq in truncate_exceptional_pvec_entries
> 
> I do not find a good way to fix, so I only report.
> This is found by my static analysis tool (DSAC).

Thanks for report but this is a false positive. Note that the lock is
acquired only if we are not operating on DAX mapping but we can get to
dax_delete_mapping_entry() only if we are operating on DAX mapping.

								Honza

-- 
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR



[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux