On Thu, 2008-03-06 at 13:27 +0100, Christoph Hellwig wrote: > On Wed, Mar 05, 2008 at 01:54:47PM -0500, David P. Quigley wrote: > > This factors out the part of the vfs_setxattr function that performs the > > setting of the xattr and its notification. This is needed so the SELinux > > implementation of inode_setsecctx can handle the setting of it's xattr while > > maintaining the proper separation of layers. > > Looks good, but I'm not entirely sure do_setxattr is a good name for > this exported functionality. __vfs_setxattr_noperm might be better. > > Please also add a kerneldoc comment for each new global function. Will do. I have to release a new patch set with the hook changed to take a bool instead of a flag so you should see this updated sometime later today. Dave -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html