Greg Kurz wrote on Thu, Aug 02, 2018:
> > @@ -443,9 +444,9 @@ static int rdma_request(struct p9_client *client, struct p9_req_t *req)
> > **/
> > if (unlikely(atomic_read(&rdma->excess_rc) > 0)) {
> > if ((atomic_sub_return(1, &rdma->excess_rc) >= 0)) {
> > - /* Got one ! */
> > - kfree(req->rc);
> > - req->rc = NULL;
> > + /* Got one! */
> > + kfree(req->rc.sdata);
>
> Shouldn't this be p9_fcall_fini(&req->rc) ?
Right, I failed at bookkeeping, I changed that in the next patch but it
should have been done now.
Will add p9_fcall_fini to headers/export in this patch instead of the
next
> The rest looks good, so, with that fixed, you can add:
>
> Reviewed-by: Greg Kurz <groug@xxxxxxxx>
Thanks!
--
Dominique
