Re: [PATCH] fs/binfmt_elf_fdpic: remove redundant condition check in writenote

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: zhong jiang <zhongjiang@xxxxxxxxxx>
Subject: Re: [PATCH] fs/binfmt_elf_fdpic: remove redundant condition check in writenote
From: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
Date: Thu, 2 Aug 2018 04:05:22 +0100
Cc: linux-fsdevel@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <1533175474-17785-1-git-send-email-zhongjiang@huawei.com>
User-agent: Mutt/1.9.1 (2017-09-22)

On Thu, Aug 02, 2018 at 10:04:34AM +0800, zhong jiang wrote:
> It is unncessary to use double test for a expression. so just
> remove one of them.

... except when something in that expression might have side effects,
that is.

References:
- [PATCH] fs/binfmt_elf_fdpic: remove redundant condition check in writenote
  - From: zhong jiang

Prev by Date: Re: [PATCH] fs/binfmt_elf: remove the same condition check
Next by Date: Re: Commit "new primitive: discard_new_inode()" introduces a problem
Previous by thread: Re: [PATCH] fs/binfmt_elf_fdpic: remove redundant condition check in writenote
Next by thread: [PATCH dhowells/mount-api] fs: typo fix in legacy_parse_param
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [Samba] [Device Mapper] [CEPH Development]

Powered by Linux