Re: [PATCH] fs/binfmt_elf: remove the same condition check

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: zhong jiang <zhongjiang@xxxxxxxxxx>
Subject: Re: [PATCH] fs/binfmt_elf: remove the same condition check
From: Matthew Wilcox <willy@xxxxxxxxxxxxx>
Date: Wed, 1 Aug 2018 19:34:12 -0700
Cc: viro@xxxxxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <1533175228-17547-1-git-send-email-zhongjiang@huawei.com>
User-agent: Mutt/1.9.2 (2017-12-15)

On Thu, Aug 02, 2018 at 10:00:28AM +0800, zhong jiang wrote:
> dump_align is used to double check in a expression. It is redundant.
> so just remove one of them.

You're wrong.  Functions in C can have side-effects (and this one does).

Follow-Ups:
- Re: [PATCH] fs/binfmt_elf: remove the same condition check
  - From: zhong jiang

References:
- [PATCH] fs/binfmt_elf: remove the same condition check
  - From: zhong jiang

Prev by Date: [PATCH] fs/binfmt_elf_fdpic: remove redundant condition check in writenote
Next by Date: Re: Commit "new primitive: discard_new_inode()" introduces a problem
Previous by thread: [PATCH] fs/binfmt_elf: remove the same condition check
Next by thread: Re: [PATCH] fs/binfmt_elf: remove the same condition check
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [Samba] [Device Mapper] [CEPH Development]

Powered by Linux