On Wed, Jul 4, 2018 at 3:22 AM, Andreas Gruenbacher <agruenba@xxxxxxxxxx> wrote: > On 3 July 2018 at 23:39, Darrick J. Wong <darrick.wong@xxxxxxxxxx> wrote: >> On Mon, Jul 02, 2018 at 07:52:41PM +0200, Andreas Gruenbacher wrote: >>> On 2 July 2018 at 17:43, Souptick Joarder <jrdr.linux@xxxxxxxxx> wrote: >>> > Return type has been changed to vm_fault_t type for >>> > iomap_page_mkwrite(). >>> > >>> > see commit 1c8f422059ae ("mm: change return type to >>> > vm_fault_t") for reference. >>> > >>> > Signed-off-by: Souptick Joarder <jrdr.linux@xxxxxxxxx> >>> > Reviewed-by: Matthew Wilcox <mawilcox@xxxxxxxxxxxxx> >> >> I don't recall Christoph [now cc'd] rescinding his NAK of the previous >> version of this patch[1]. Has he changed his mind since May? > > Oops, a reply gone wrong -- I was meaning to reply to Souptick > Joarder's gfs2 change which I've added to the gfs2 for-next branch. > Not the iomap change. Sorry for the confusion. > >> [1] https://spinics.net/lists/linux-fsdevel/msg126032.html >> >> Now granted I didn't have a problem with the code (and applied the xfs >> version to 4.18 after monitoring to satisfy myself that nothing >> particularly weird happened during 4.17) but seeing as most of the iomap >> changes have gone through hch's review and landed via the xfs tree... Darrick, is this patch going to 4.19 through xfs tree ?