On Tue, Jul 17, 2018 at 03:13:49PM +0200, Christoph Hellwig wrote: > On Mon, Jul 16, 2018 at 03:07:16PM +0800, Shan Hai wrote: > > The simple definition of a macro is enough for the include guard, it's not > > necessary to assign a value to it, so remove the assignment. > > > > Signed-off-by: Shan Hai <shan.hai@xxxxxxxxxx> > > And what is the exact benefit of changing this? doesn't seem worthwhile to me either. If anything's going to change, it should probably be _LINUX_IOMAP_H (insofaras we have a standard for include guards, a single _ seems to be preferred)