On Wed, Jul 11, 2018 at 11:26 AM, Jan Kara <jack@xxxxxxx> wrote: > On Wed 11-07-18 10:58:24, Amir Goldstein wrote: >> On Tue, Jul 10, 2018 at 1:02 PM, Jan Kara <jack@xxxxxxx> wrote: >> > Chunk replacement code is very similar for the cases where we grow or >> > shrink chunk. Factor the code out into a common helper function. >> > >> > Signed-off-by: Jan Kara <jack@xxxxxxx> >> >> Ack. Nice re-factoring. > > Thanks. BTW, I didn't add your Acked-by tags because it wasn't obvious to > me whether you meant them as an official tag-worthy statement. So do want > me to add the tags or do you prefer to stay "anonymous reviewer" ;)? > Don't feel confident enough with Reviewed-by/Acked-by on this series, just letting you know that I eyeballed your patches FWIW ;-) I'm down to the last one, which is agonizing to make sure nothing is missed from the diff. At this point [10/10] I'd rather review the final code. Can you push the work to a branch. Thanks, Amir.