On Mon, Jul 09, 2018 at 04:31:59PM +0100, David Howells wrote: > -int __mnt_is_readonly(struct vfsmount *mnt) > +bool __mnt_is_readonly(struct vfsmount *mnt) > { > if (mnt->mnt_flags & MNT_READONLY) > - return 1; > + return true; > if (sb_rdonly(mnt->mnt_sb)) > - return 1; > - return 0; > + return true; > + return false; Egads... *If* you go for bool here, why not return (mnt->mnt_flags & MNT_READONLY) || sb_rdonly(mnt->mnt_sb); and be done with that?