On Sat, Jul 07, 2018 at 06:05:17PM +0800, kbuild test robot wrote: > Hi Omar, > > Thank you for the patch! Perhaps something to improve: > > [auto build test WARNING on linus/master] > [also build test WARNING on v4.18-rc3 next-20180706] > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] > > url: https://github.com/0day-ci/linux/commits/Omar-Sandoval/proc-kcore-improvements/20180707-052548 > reproduce: > # apt-get install sparse > make ARCH=x86_64 allmodconfig > make C=1 CF=-D__CHECK_ENDIAN__ > > > sparse warnings: (new ones prefixed by >>) > > include/linux/nodemask.h:265:16: sparse: expression using sizeof(void) > include/linux/nodemask.h:271:16: sparse: expression using sizeof(void) > >> fs//proc/kcore.c:328:23: sparse: expression using sizeof(void) > >> fs//proc/kcore.c:328:23: sparse: expression using sizeof(void) Not sure why this confuses sparse. Maybe because it's #define elfhdr elf64_hdr. > fs//proc/kcore.c:368:23: sparse: expression using sizeof(void) > fs//proc/kcore.c:368:23: sparse: expression using sizeof(void) > >> fs//proc/kcore.c:384:49: sparse: missing braces around initializer This is > > 384 struct elf_prstatus prstatus = {0}; GCC doesn't complain, but I guess I can change it to "= {};", which isn't strict C89 but both GCC and sparse are happy with.