On Thu, 2018-07-05 at 16:58 -0700, Andrew Morton wrote: > On Tue, 03 Jul 2018 14:45:15 +0800 Ian Kent <raven@xxxxxxxxxx> wrote: > > > Initial patch contributed by Tomas Bortoli. > > > > The autofs subsystem does not check that the "path" parameter is > > present for all cases where it is required when it is passed in > > via the "param" struct. > > > > In particular it isn't checked for the AUTOFS_DEV_IOCTL_OPENMOUNT_CMD > > ioctl command. > > > > To solve it, modify validate_dev_ioctl() function to check that a > > path has been provided for ioctl commands that require it. > > > > Signed-off-by: Tomas Bortoli <tomasbortoli@xxxxxxxxx> > > Signed-off-by: Ian Kent <raven@xxxxxxxxxx> > > Reported-by: syzbot+60c837b428dc84e83a93@xxxxxxxxxxxxxxxxxxxxxxxxx > > So who is the primary author of this? I'm assuming "Tomas" from the > signoff order? Yes, Tomas was the originator but I did change it somewhat so added my Signed-off-by as well. > > The way of signifying this is to put the other author's From: line right > at the top of changelog. Oh, ok, will do in future, although my changes were fairly significant. IMHO it was a joint effort more or less equal by both of us. Nevertheless I would have been happy to list Tomas as the From author. > > I assume this is a root-only bug, so we don't need to backport the fix? It is, so yes that's right, unless Tomas has other recommendations. Ian
