On 07-01 10:10, Dave Chinner wrote: > On Fri, Jun 29, 2018 at 09:37:27PM -0500, Steve French wrote: > > I have been looking at i/o patterns from various copy tools on Linux, > > and it is pretty discouraging - I am hoping that I am forgetting an > > important one that someone can point me to ... > > > > Some general problems: > > 1) if source and target on the same file system it would be nice to > > call the copy_file_range syscall (AFAIK only test tools call that), > > although in some cases at least cp can do it for --reflink > > copy_file_range() should be made to do the right thing in as many > scnearios as we can document, and then switch userspace over to use > it at all times. Aggregate all the knowledge in one place, where we > know what the filesystem implementations are and can get hints to do > the right thing. We have discussed this earlier in https://www.spinics.net/lists/linux-fsdevel/msg125401.html and Christoph suggested that there is no point adding new flags for holes. Do you have a different opinion? The same is with coreutils maintainer where he suggested adding flags to perform everything with respect to holes in the kernel. -- Goldwyn
