On Fri, Jun 29, 2018 at 6:37 AM Christoph Hellwig <hch@xxxxxx> wrote:
>
> The big aio poll revert broke various network protocols that don't
> implement ->poll as a patch in the aio poll serie removed sock_no_poll
> and made the common code handle this case.
Hmm. I just did the revert of commit 984652dd8b1f ("net: remove
sock_no_poll") in my tree.
But I haven't pushed it out, and your patch is certainly smaller/nicer
than the revert.
That said, the revert does have the advantage of avoiding a
conditional in the network poll() function (at the cost of a more
expensive indirect call for when sock_no_poll actually triggers, but
only "odd" network protocols have that).
Hmm. I'll have to think about it.
Linus
