On Thu, Jun 28, 2018 at 2:30 PM Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:
>
> > Again, locking is permitted. It's not great, but it's not against the rules.
>
> Me: a *LOT* of ->poll() instances only block in __pollwait() called (indirectly)
> on the first pass.
>
> You: They are *all* supposed to do it.
>
> Me: <examples of instances that block elsewhere>
Oh, I thought you were talking about the whole "first pass" adding to
wait queues, as opposed to doing it on the second pass.
The *blocking* is entirely immaterial. I didn't even react to it,
because it's simply not an issue.
I don't understand why you're even hung up about it.
The only reason "blocking" seems to be an issu eis because AIO has
shit-for-brains and wanted to do poll() under the spinlock.
But that's literally just AIO being confused garbage. It has zero
relevance for anything else.
Linus
