And add a comment about why we don't need it. Signed-off-by: Matthew Wilcox <willy@xxxxxxxxxxxxx> --- net/9p/client.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/net/9p/client.c b/net/9p/client.c index 602f76de388a..2dce8d8307cc 100644 --- a/net/9p/client.c +++ b/net/9p/client.c @@ -436,13 +436,9 @@ void p9_client_cb(struct p9_client *c, struct p9_req_t *req, int status) { p9_debug(P9_DEBUG_MUX, " tag %d\n", req->tc->tag); - /* - * This barrier is needed to make sure any change made to req before - * the other thread wakes up will indeed be seen by the waiting side. - */ - smp_wmb(); req->status = status; + /* wake_up is an implicit write memory barrier */ wake_up(&req->wq); p9_debug(P9_DEBUG_MUX, "wakeup: %d\n", req->tc->tag); } -- 2.18.0