Re: [PATCH 1/1] iomap: Direct I/O for inline data

[kbuild test robot <lkp@xxxxxxxxx>]

Hi Andreas,

I love your patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v4.18-rc2 next-20180626]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Andreas-Gruenbacher/iomap-Direct-I-O-for-inline-data/20180627-084229
config: x86_64-randconfig-x015-201825 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All error/warnings (new ones prefixed by >>):

   In file included from include/linux/kernel.h:10:0,
                    from include/linux/list.h:9,
                    from include/linux/module.h:9,
                    from fs/iomap.c:14:
   fs/iomap.c: In function 'iomap_dio_actor_inline':
>> fs/iomap.c:971:56: error: 'struct iomap' has no member named 'inline_data'
     BUG_ON(pos + length > PAGE_SIZE - offset_in_page(iomap->inline_data));
                                                           ^
   include/linux/compiler.h:77:42: note: in definition of macro 'unlikely'
    # define unlikely(x) __builtin_expect(!!(x), 0)
                                             ^
>> fs/iomap.c:971:2: note: in expansion of macro 'BUG_ON'
     BUG_ON(pos + length > PAGE_SIZE - offset_in_page(iomap->inline_data));
     ^~~~~~
>> fs/iomap.c:971:36: note: in expansion of macro 'offset_in_page'
     BUG_ON(pos + length > PAGE_SIZE - offset_in_page(iomap->inline_data));
                                       ^~~~~~~~~~~~~~
   fs/iomap.c:977:16: error: 'struct iomap' has no member named 'inline_data'
       memset(iomap->inline_data + size, 0, pos - size);
                   ^~
   fs/iomap.c:978:32: error: 'struct iomap' has no member named 'inline_data'
      copied = copy_from_iter(iomap->inline_data + pos, length, iter);
                                   ^~
   fs/iomap.c:985:30: error: 'struct iomap' has no member named 'inline_data'
      copied = copy_to_iter(iomap->inline_data + pos, length, iter);
                                 ^~

vim +971 fs/iomap.c

   964	
   965	static loff_t iomap_dio_actor_inline(struct inode *inode, struct iomap_dio *dio,
   966			struct iomap *iomap, loff_t pos, loff_t length)
   967	{
   968		struct iov_iter *iter = dio->submit.iter;
   969		size_t copied;
   970	
 > 971		BUG_ON(pos + length > PAGE_SIZE - offset_in_page(iomap->inline_data));
   972	
   973		if (dio->flags & IOMAP_DIO_WRITE) {
   974			loff_t size = inode->i_size;
   975	
   976			if (pos > size)
   977				memset(iomap->inline_data + size, 0, pos - size);
   978			copied = copy_from_iter(iomap->inline_data + pos, length, iter);
   979			if (copied) {
   980				if (pos + copied > size)
   981					i_size_write(inode, pos + copied);
   982				mark_inode_dirty(inode);
   983			}
   984		} else {
   985			copied = copy_to_iter(iomap->inline_data + pos, length, iter);
   986		}
   987		dio->size += copied;
   988		return copied;
   989	}
   990	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip