On 06-21 05:22, Christoph Hellwig wrote:
> On Wed, Jun 20, 2018 at 02:39:10PM -0500, Goldwyn Rodrigues wrote:
> > -static inline struct dentry *d_backing_dentry(struct dentry *upper)
> > +static inline struct inode *d_backing_inode(const struct dentry *dentry)
> > {
> > - return upper;
> > + return d_inode(dentry);
> > }
>
> Why even keep both functions around then?
>
Yes, I would love to get rid of them. There are just too many users.
1332 users of d_inode
176 users of d_backing_inode
Similarly, file_inode() with 1020 users is another candidate.
Introduced in -
496ad9aa8ef4 ("new helper: file_inode(file)")
but made unnecessary in -
dd37978c50bc ("cache the value of file_inode() in struct file")
I will work on a patch to clean all.
--
Goldwyn
