Re: [PATCH] include: dax: new-return-type-vm_fault_t

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jun 20, 2018 at 10:51:49PM +0530, Souptick Joarder wrote:
> On Wed, Jun 20, 2018 at 10:50 PM, Souptick Joarder <jrdr.linux@xxxxxxxxx> wrote:
> > Use new return type vm_fault_t for fault handler. For now,
> > this is just documenting that the function returns a VM_FAULT
> > value rather than an errno. Once all instances are converted,
> > vm_fault_t will become a distinct type.

> As part of
> commit ab77dab46210 ("fs/dax.c: use new return type vm_fault_t")
> I missed this change which leads to compilation error.
> Sorry about it.
> 
> This patch need to be in 4.18-rc-2/x on priority.

It only leads to a compilation error for you; the rest of us are still
using typedef int vm_fault_t, so it's not a mismatch.  It'd be nice to get
this fixed, but it's not a priority.

Sorry I didn't spot this during my review.



[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux