On Mon, Jun 11, 2018 at 6:24 PM, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
> On Mon, Jun 11, 2018 at 09:19:01AM +0200, Miklos Szeredi wrote:
>> We don't. Obviously need to make sure to only ever do ioctl's in
>> overlayfs that have a common definition across filesystems. Not a lot
>> of those, luckily...
>
> Which are those? If they are common and possibly called from kernel
> code they should probably be made into methods instead.
FS_IOC*
Haven't looked deeply. For now overlayfs just implements
FS_IOC_{GET|SET}FLAGS because some of these flags are quite generic
and implementing them on the overlay is easy.
Yes, turning into a method makes sense.
Thanks,
Miklos
