On Thu, Jun 14, 2018 at 12:33 PM, Tetsuo Handa
<penguin-kernel@xxxxxxxxxxxxxxxxxxx> wrote:
> On 2018/06/11 16:39, Dmitry Vyukov wrote:
>> On Mon, Jun 11, 2018 at 9:30 AM, Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
>>> On Sun, Jun 10, 2018 at 11:47:56PM +0900, Tetsuo Handa wrote:
>>>
>>>> This looks quite strange that nobody is holding percpu_rw_semaphore for
>>>> write but everybody is stuck trying to hold it for read. (Since there
>>>> is no "X locks held by ..." line without followup "#0:" line, there is
>>>> no possibility that somebody is in TASK_RUNNING state while holding
>>>> percpu_rw_semaphore for write.)
>>>>
>>>> I feel that either API has a bug or API usage is wrong.
>>>> Any idea for debugging this?
>>>
>>> Look at percpu_rwsem_release() and usage. The whole fs freezer thing is
>>> magic.
>>
>> Do you mean that we froze fs? We tried to never-ever issue
>> ioctl(FIFREEZE) during fuzzing. Are there other ways to do this?
>>
>
> Dmitry, can you try this patch? If you can get
>
> [ 48.080875] ================================================
> [ 48.083648] WARNING: lock held when returning to user space!
> [ 48.086384] 4.17.0+ #588 Tainted: G T
> [ 48.088890] ------------------------------------------------
> [ 48.091447] a.out/1243 is leaving the kernel with locks still held!
> [ 48.093487] 3 locks held by a.out/1243:
> [ 48.094964] #0: 00000000148ae74c (sb_writers#8){++++}, at: percpu_down_write+0x1d/0x110
> [ 48.097622] #1: 000000001c9e7d4d (sb_pagefaults){++++}, at: percpu_down_write+0x1d/0x110
> [ 48.100432] #2: 000000003c3d2e71 (sb_internal){++++}, at: percpu_down_write+0x1d/0x110
>
> with this patch, there is a way to return to userspace with locks held.
> If you got possible deadlock warning messages, it will be great.
>
> If you cannot reproduce with this patch, I think we need a git tree to try
> this patch. But linux-next.git is not yet re-added to the list of trees to
> test and linux.git is not suitable for temporary debug patch...
>
>
>
> From 5ba3a5bc6401a937d30a9e3421ac2a29ee99588f Mon Sep 17 00:00:00 2001
> From: Tetsuo Handa <penguin-kernel@xxxxxxxxxxxxxxxxxxx>
> Date: Thu, 14 Jun 2018 16:14:55 +0900
> Subject: [PATCH] locking/lockdep: Add config option to allow lockdep splat
> upon ioctl(FIFREEZE) request
>
> syzbot is hitting hung task problems at __sb_start_write() [1]. While hung
> tasks at __sb_start_write() suggest that filesystem was frozen, syzbot is
> not doing ioctl(FIFREEZE) requests. Therefore, the root cause of hung tasks
> is currently unknown. If there are other paths to freeze filesystem and
> return to userspace without thawing, syzbot needs to avoid testing such
> paths. Therefore, this patch adds a kernel config option which allows
> lockdep to splat if syzbot found such paths.
>
> [1] https://syzkaller.appspot.com/bug?id=287aa8708bc940d0ca1645223c53dd4c2d203be6
>
> Signed-off-by: Tetsuo Handa <penguin-kernel@xxxxxxxxxxxxxxxxxxx>
> Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> Cc: Will Deacon <will.deacon@xxxxxxx>
> Cc: Dmitry Vyukov <dvyukov@xxxxxxxxxx>
> ---
> fs/super.c | 4 ++++
> lib/Kconfig.debug | 13 +++++++++++++
> 2 files changed, 17 insertions(+)
>
> diff --git a/fs/super.c b/fs/super.c
> index 50728d9..eb51268 100644
> --- a/fs/super.c
> +++ b/fs/super.c
> @@ -1428,10 +1428,12 @@ static void sb_wait_write(struct super_block *sb, int level)
> */
> static void lockdep_sb_freeze_release(struct super_block *sb)
> {
> +#ifndef CONFIG_LOCKDEP_REPORT_FSFREEZE_FROM_USERSPACE
> int level;
>
> for (level = SB_FREEZE_LEVELS - 1; level >= 0; level--)
> percpu_rwsem_release(sb->s_writers.rw_sem + level, 0, _THIS_IP_);
> +#endif
> }
>
> /*
> @@ -1439,10 +1441,12 @@ static void lockdep_sb_freeze_release(struct super_block *sb)
> */
> static void lockdep_sb_freeze_acquire(struct super_block *sb)
> {
> +#ifndef CONFIG_LOCKDEP_REPORT_FSFREEZE_FROM_USERSPACE
> int level;
>
> for (level = 0; level < SB_FREEZE_LEVELS; ++level)
> percpu_rwsem_acquire(sb->s_writers.rw_sem + level, 0, _THIS_IP_);
> +#endif
> }
>
> static void sb_freeze_unlock(struct super_block *sb)
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index d543c65..e119d19 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -1170,6 +1170,19 @@ config DEBUG_LOCK_ALLOC
> spin_lock_init()/mutex_init()/etc., or whether there is any lock
> held during task exit.
>
> +config LOCKDEP_REPORT_FSFREEZE_FROM_USERSPACE
> + bool "Allow lockdep splat upon ioctl(FIFREEZE) request"
> + depends on PROVE_LOCKING
> + default n
> + help
> + Freezing filesystems and not thawing shortly will kill the system with
> + hung tasks. Since ioctl(FIFREEZE) request returns to userspace with
> + locks held, in order to suppress lockdep splat messages, information
> + of held locks is cleared without actually releasing locks held. But
> + doing so might hide possible deadlock bugs. Thus, this option allows
> + lockdep splat if ioctl(FIFREEZE) is requested, in order to help
> + finding possible deadlock bugs.
> +
> config LOCKDEP
> bool
> depends on DEBUG_KERNEL && LOCK_DEBUGGING_SUPPORT
> --
> 1.8.3.1
I've tried replying 5 logs with this patch, but I don't see that we
return to user-space with locks held, nor deadlock reports.
What I've noticed is that all these logs contain lots of error
messages around block subsystem. Perhaps if we can identify the common
denominator across error messages in different logs, we can find the
one responsible for hangs.
[ 443.933790] FAT-fs (loop3): Directory bread(block 137) failed
[ 444.077580] attempt to access beyond end of device
[ 444.082571] loop3: rw=2049, want=310, limit=128
[ 444.087278] buffer_io_error: 238 callbacks suppressed
[ 444.087291] Buffer I/O error on dev loop3, logical block 309, lost
async page write
[ 444.100466] attempt to access beyond end of device
[ 444.105465] loop3: rw=2049, want=311, limit=128
[ 444.110160] Buffer I/O error on dev loop3, logical block 310, lost
async page write
[ 444.118684] attempt to access beyond end of device
[ 444.123660] loop3: rw=2049, want=312, limit=128
[ 444.225240] attempt to access beyond end of device
[ 444.230192] loop3: rw=2049, want=2153, limit=128
[ 444.244874] attempt to access beyond end of device
[ 444.250144] loop3: rw=0, want=310, limit=128
[ 199.713659] print_req_error: I/O error, dev loop0, sector 0
[ 199.714970] Buffer I/O error on dev loop0, logical block 0, lost
async page write
