On Mon, Jun 11, 2018 at 09:16:56PM +0100, Al Viro wrote: > On Mon, Jun 11, 2018 at 11:14:55PM +0300, Cyrill Gorcunov wrote: > > On Thu, Jun 7, 2018 at 10:07 PM Andrei Vagin <avagin@xxxxxxxxxxxxx> wrote: > > > > > ... > > > > > + > > > > > + error = import_iovec(READ, uiov, nr_segs, > > > > > + ARRAY_SIZE(iovstack), &iov, &iter); > > > > > > > > import_iovec should be called with WRITE, if we are going to call > > > > vmsplice_to_pipe(). > > > > > > We caught this issue, when we run CRIU tests for > > > https://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git/log/?h=for-next > > > > > > CRIU fails with errors like this: > > > > > > pie: 38: Error (criu/pie/parasite.c:89): Can't splice pages to pipe (-14/2/0) > > > > > It is already in the master tree, or still in the linux-next? > > Still in -next; I have a fixed variant, hadn't pushed it out yet. Al, can I ask you to push the fixed variant to -next or revert this one. We have a robot which regularly runs CRIU tests on -next, and now it is blocked by this issue. Thanks, Andrei
