On Mon, Jun 11, 2018 at 10:12 AM, Laurent Dufour <ldufour@xxxxxxxxxxxxxxxxxx> wrote: > On 09/06/2018 01:50, Dan Williams wrote: >> Define a local 'vma' variable rather than repetitively de-referencing >> the passed in 'struct vm_fault *' instance. > > Hi Dan, > > Why is this needed ? > > I can't see the real benefit, having the vma deferenced from the vm_fault > structure is not obfuscating the code and it eases to follow the use of vmf->vma. > > Am I missing something ? No, and now that I take another look it's just noise. I'll drop it. Thanks for the poke.