On Thu, Jun 7, 2018 at 8:02 AM Jan Kara <jack@xxxxxxx> wrote:
>
> several fsnotify cleanups unifying handling of different watch
> types.
Grr.
Why is this growing things like "fsnotify_obj_inode()" helpers in <linux/fs.h>?
It has nothing to do with generic fs code. The only things that can
possibly use that already have to include fsnotify-specific headers,
where things like this belong.
It also adds a "struct fsnotify_obj i_fsnotify" to the struct inode,
and marks it "packed", so now architectures that have issues with
alignment might have issues depending on random changes to 'struct
inode'.
Plus it (again) causes more disturbance to a core header file that
fsnotify shouldn't touch. We had a forward declaration and a pointer.
So no. I'm not pulling this. I don't think it's a "cleanup". Maybe it
cleans up the fsnotify code, but it uglifies code that is much more
important.
Linus
