On Sat, Jun 02, 2018 at 11:57:13AM +0200, Andreas Gruenbacher wrote: > Add a write_end operation to struct iomap_ops to provide a way of > overriding the default behavior of iomap_write_end. This will be used > for implementing data journaling in gfs2: in the data journaling case, > pages are written into the journal before being written back to their > proper on-disk locations. Please names this page_write_end and make it an optional callout just for the additional functionality, that is keep the call to iomap_write_end hardcoded in iomap.c, just call the new method before it. > + > +struct iomap_write_args { > + const struct iomap_ops *ops; > + struct iov_iter *iter; > +}; Also I wonder if we should just pass the iomap_ops diretly to the actor callback.