On Thu, May 31, 2018 at 09:00:38AM +1000, Dave Chinner wrote: > > -/* > > - * Seek for SEEK_DATA / SEEK_HOLE within @page, starting at @lastoff. > > - * > > - * Returns the offset within the file on success, and -ENOENT otherwise. > > - */ > > -static loff_t > > -page_seek_hole_data(struct page *page, loff_t lastoff, int whence) > > +static bool > > +page_seek_hole_data(struct inode *inode, struct page *page, loff_t *lastoff, > > + int whence) > > Can we keep the comment explaining the return value? The old comment isn't going to be correct. I've added back a changed comment, akthough I don't really think it helps. > > + const struct address_space_operations *ops = inode->i_mapping->a_ops; > > + unsigned int bsize = i_blocksize(inode), off; > > Split this into two lines. We've got a pattern here - I really like it that way..
