On Wed, May 30, 2018 at 11:02:08AM +0100, Steven Whitehouse wrote: > In that case, maybe it would be simpler to drop it for GFS2. Unless we > are getting a lot of benefit from it, then we should probably just follow > the generic pattern here. Eventually we'll move everything to iomap, so > that the bh mapping interface will be gone. That implies that we might be > able to drop it now, to avoid this complication during the conversion. > > Andreas, do you see any issues with that? I suspect it actually is doing the wrong thing today. It certainly does for SSDs, and it probably doesn't do a useful thing for modern disks with intelligent caches either.