> + if (gfs2_is_stuffed(ip)) { > + unstuff = pos + length > gfs2_max_stuffed_size(ip); > + > + if (!unstuff) { > + iomap->page = grab_cache_page_write_begin( > + inode->i_mapping, 0, flags); > + ret = -ENOMEM; > + if (!iomap->page) > + goto out; > + > + if (!PageUptodate(iomap->page)) { > + ret = stuffed_readpage(ip, iomap->page); > + if (ret) > + goto out; > + } > + } > + } grab_cache_page_write_begin needs to remain in iomap. Please just set up a pointer for later copying here. This will be important to support e.g. iomap_readpage(s) and to easily support direct I/O from inline data (just copy to/from the stuffed data pointer in iomap).