Re: [PATCH v5 14/14] gfs2: Handle stuffed files in iomap_{begin,end}

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> +	if (gfs2_is_stuffed(ip)) {
> +		unstuff = pos + length > gfs2_max_stuffed_size(ip);
> +
> +		if (!unstuff) {
> +			iomap->page = grab_cache_page_write_begin(
> +					inode->i_mapping, 0, flags);
> +			ret = -ENOMEM;
> +			if (!iomap->page)
> +				goto out;
> +
> +			if (!PageUptodate(iomap->page)) {
> +				ret = stuffed_readpage(ip, iomap->page);
> +				if (ret)
> +					goto out;
> +			}
> +		}
> +	}

grab_cache_page_write_begin needs to remain in iomap.  Please just
set up a pointer for later copying here.

This will be important to support e.g. iomap_readpage(s) and to easily
support direct I/O from inline data (just copy to/from the stuffed
data pointer in iomap).



[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux