Re: [PATCH 22/34] xfs: make xfs_writepage_map extent map centric

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Brian Foster <bfoster@xxxxxxxxxx>
Subject: Re: [PATCH 22/34] xfs: make xfs_writepage_map extent map centric
From: Christoph Hellwig <hch@xxxxxx>
Date: Tue, 29 May 2018 15:08:46 +0200
Cc: Christoph Hellwig <hch@xxxxxx>, linux-xfs@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, Dave Chinner <dchinner@xxxxxxxxxx>
In-reply-to: <20180529112630.GA107328@bfoster.bfoster>
User-agent: Mutt/1.5.17 (2007-11-01)

On Tue, May 29, 2018 at 07:26:31AM -0400, Brian Foster wrote:
> What exactly is the trivial check? Can you show the code please?

ASSERT(file_offset > i_size_read(inode)) in the !count block
at the end of xfs_writepage_map.

(file_offset replaced with page_offset(page) + offset for the mainline
code).

Follow-Ups:
- Re: [PATCH 22/34] xfs: make xfs_writepage_map extent map centric
  - From: Brian Foster

References:
- buffered I/O without buffer heads in xfs and iomap v3
  - From: Christoph Hellwig
- [PATCH 22/34] xfs: make xfs_writepage_map extent map centric
  - From: Christoph Hellwig
- Re: [PATCH 22/34] xfs: make xfs_writepage_map extent map centric
  - From: Brian Foster
- Re: [PATCH 22/34] xfs: make xfs_writepage_map extent map centric
  - From: Christoph Hellwig
- Re: [PATCH 22/34] xfs: make xfs_writepage_map extent map centric
  - From: Brian Foster
- Re: [PATCH 22/34] xfs: make xfs_writepage_map extent map centric
  - From: Christoph Hellwig
- Re: [PATCH 22/34] xfs: make xfs_writepage_map extent map centric
  - From: Brian Foster
- Re: [PATCH 22/34] xfs: make xfs_writepage_map extent map centric
  - From: Christoph Hellwig
- Re: [PATCH 22/34] xfs: make xfs_writepage_map extent map centric
  - From: Brian Foster

Prev by Date: Re: [kbuild-all] [vfs:hch.aio 7/40] include/linux/syscalls.h:233:18: warning: 'sys_io_pgetevents' alias between functions of incompatible types 'long int(aio_context_t, long int, long int, struct io_event *, struct timespec *, const struct __aio_sigset *)' and 'long int(long int, long int, long int, long int, long int, long int)'
Next by Date: Re: dm: writecache: add DAX dependency
Previous by thread: Re: [PATCH 22/34] xfs: make xfs_writepage_map extent map centric
Next by thread: Re: [PATCH 22/34] xfs: make xfs_writepage_map extent map centric
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [Samba] [Device Mapper] [CEPH Development]