On Mon 28-05-18 09:10:43, Randy Dunlap wrote: > On 05/28/2018 02:21 AM, Michal Hocko wrote: [...] > > +reclaim context or when a transaction context nesting would be possible > > +via reclaim. The corresponding restore function when the critical > > "The corresponding restore ... ends." << That is not a complete sentence. > It's missing something. Dave has pointed that out. "The restore function should be called when the critical section ends." > > +section ends. All that ideally along with an explanation what is > > +the reclaim context for easier maintenance. > > + > > +Please note that the proper pairing of save/restore function allows > > +nesting so it is safe to call ``memalloc_noio_save`` respectively > > +``memalloc_noio_restore`` from an existing NOIO or NOFS scope. > > Please note that the proper pairing of save/restore functions allows > nesting so it is safe to call ``memalloc_noio_save`` or > ``memalloc_noio_restore`` respectively from an existing NOIO or NOFS scope. Fixed. Thanks -- Michal Hocko SUSE Labs